This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
[TxPool] Fix duplicate transactions in account #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrajovic
requested review from
zivkovicmilos,
lazartravica and
Kourin1996
as code owners
zivkovicmilos
approved these changes
Jun 3, 2022
0xAleksaOpacic
approved these changes
Jun 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of two identical transactions ending up back-to-back inside an account. This bug is the true source of the numerous
failed to apply tx: incorrect nonceerrors.The second transaction is a gossip of the first, but because indexing happens in
handleEnqueueRequestboth of them complete the preceding call toaddTxbypassing the (now deprecated) check forErrAlreadyKnown.Changes include
Checklist
Testing
Additional comments
Fixes EDGE-585